c_meyer/pxt-calliope
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add check in RefObject::decr(); Fix decr() in removeAt see https://github.com/Microsoft/pxt/issues/3093 (#544)

Browse Source
This commit is contained in:
Michał Moskal
2017-10-01 22:39:25 +01:00
committed by Peli de Halleux
parent faae856e88
commit 9382535d29
2 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
libs/core/pxt.cpp
View File

@ -394,10 +394,7 @@ namespace pxt {
uint32_t RefCollection::removeAt(int i)
{
if (isRef())
{
decr(head.get(i));
}
// no decr() - we return the result
return head.remove(i);
}
@ -464,7 +461,8 @@ namespace pxt {
{
int idx = indexOf(x, 0);
if (idx >= 0) {
removeAt(idx);
uint32_t elt = removeAt(idx);
if (isRef()) decr(elt);
return 1;
}
return 0;