From fc83cc5d5bd41edfcad34895a89dd71447d73cad Mon Sep 17 00:00:00 2001 From: Sam El-Husseini <16690124+samelhusseini@users.noreply.github.com> Date: Wed, 20 Jun 2018 16:29:03 -0700 Subject: [PATCH] Fix note field editor authoring such that it limits the notes that show up (#715) --- libs/music/piano.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libs/music/piano.ts b/libs/music/piano.ts index aa3be954..dc0d7f85 100644 --- a/libs/music/piano.ts +++ b/libs/music/piano.ts @@ -1,19 +1,19 @@ namespace music { /** * Get the frequency of a note. - * @param name the note name, eg: Note.C + * @param note the note name, eg: Note.C */ //% weight=1 help=music/note-frequency //% blockId=device_note block="%note" //% shim=TD_ID //% color="#FFFFFF" colorSecondary="#FFFFFF" colorTertiary="#D67923" //% note.fieldEditor="note" note.defl="1046" - //% note.fieldOptions.editorColour="#FF1493" note.fieldOptions.decompileLiterals=true - //% note.fieldOptions.minNote=52 note.fieldOptions.maxNote=75 + //% note.fieldOptions.editorColour="#D67923" note.fieldOptions.decompileLiterals=true + //% note.fieldOptions.minNote=40 note.fieldOptions.maxNote=75 //% useEnumVal=1 //% weight=10 blockGap=8 - export function noteFrequency(name: Note): number { + export function noteFrequency(note: Note): number { //TODO fill in actual min/max note values - return name; + return note; } }