Merge remote-tracking branch 'origin/master' into disco

* bump

* bump pxt

docs/getting-started/try-tutorial.md

@@ -73,6 +73,12 @@ Verify that the program you just created shows eyes on the Brick Display, and th
 
 **Well done!**
 
+## Run it Again
+
+![EV3 Brick with Try in BrkProg_Save Folder in File Manager](/static/getting-started/try-in-file-manager.png)
+
+Use the Brick Buttons and navigate to the File Manager tab.  Open the **BrkProg_SAVE** folder, select **Try** and click the center button to run it again.
+
 ## Connect a Large Motor @unplugged
 
 Now you will learn to control the Large Motor.

docs/index-ref.json

@@ -1,3 +1,3 @@
 {
-    "appref": "v1.2.22"
+    "appref": "v1.2.26"
 }

docs/offline-app.html

@@ -388,12 +388,12 @@
         }
         function downloadWin64() {
             // TODO: Keep this link up-to-date with the desired release version
-            window.open("https://makecode.com/api/release/ev3/v1.2.22/win64");
+            window.open("https://makecode.com/api/release/ev3/v1.2.26/win64");
             tickEvent("offlineapp.download", { "target": "ev3", "platform": "win64" });
         }
         function downloadMac64() {
             // TODO: Keep this link up-to-date with the desired release version
-            window.open("https://makecode.com/api/release/ev3/v1.2.22/mac64");
+            window.open("https://makecode.com/api/release/ev3/v1.2.26/mac64");
             tickEvent("offlineapp.download", { "target": "ev3", "platform": "mac64" });
         }
     </script>

docs/stable-ref.json

@@ -0,0 +1,3 @@
+{
+    "appref": "v1.2"
+}

libs/color-sensor/color.ts

@@ -1,5 +1,4 @@
 const enum ColorSensorMode {
-    None = 0,
     //% block="reflected light intensity"
     ReflectedLightIntensity = 0,
     //% block="ambient light intensity"
@@ -56,12 +55,13 @@ namespace sensors {
     export class ColorSensor extends internal.UartSensor {
         thresholdDetector: sensors.ThresholdDetector;
         calibrating: boolean;
+        private _curr: number;
 
         constructor(port: number) {
             super(port)
-            this._setMode(ColorSensorMode.None);
             this.thresholdDetector = new sensors.ThresholdDetector(this.id());
             this.calibrating = false;
+            this._curr = 0;
         }
 
         _colorEventValue(value: number) {
@@ -104,17 +104,18 @@ namespace sensors {
                         "yellow",
                         "red",
                         "white",
-                        "brown"][this._query()];
+                        "brown"][this._curr];
                 case ColorSensorMode.AmbientLightIntensity:
                 case ColorSensorMode.ReflectedLightIntensity:
-                    return `${this._query()}%`;
+                    return `${this._curr}%`;
                 default:
-                    return this._query().toString();
+                    return this._curr.toString();
             }
         }
 
         _update(prev: number, curr: number) {
             if (this.calibrating) return; // simply ignore data updates while calibrating
+            this._curr = curr;
             if (this.mode == ColorSensorMode.Color || this.mode == ColorSensorMode.RgbRaw || this.mode == ColorSensorMode.RefRaw)
                 control.raiseEvent(this._id, this._colorEventValue(curr));
             else
@@ -178,7 +179,23 @@ namespace sensors {
         color(): ColorSensorColor {
             this.poke();
             this.setMode(ColorSensorMode.Color)
-            return this.getNumber(NumberFormat.UInt8LE, 0)
+            return this._curr;
+        }
+
+        /**
+         * Checks the color is being detected
+         * @param color the color to detect
+         */
+        //% help=sensors/color-sensor/is-color-detected
+        //% block="is **color sensor** %this|detected|%color=colorEnumPicker"
+        //% blockId=colorisColorDetectedDetected
+        //% parts="colorsensor"
+        //% blockNamespace=sensors
+        //% this.fieldEditor="ports"
+        //% weight=99 blockGap=8
+        //% group="Color Sensor"
+        isColorDetected(color: number) {
+            return this.color() == color;
         }
 
         /**
@@ -254,7 +271,7 @@ namespace sensors {
                 case LightIntensityMode.ReflectedRaw:
                     return this.reflectedLightRaw();
                 default:
-                    return this.getNumber(NumberFormat.UInt8LE, 0)
+                    return this._curr;
             }
         }
 
@@ -281,7 +298,7 @@ namespace sensors {
         reflectedLightRaw(): number {
             this.poke();
             this.setMode(ColorSensorMode.RefRaw);
-            return this.getNumber(NumberFormat.UInt16LE, 0);
+            return this._curr;
         }
 
         /**

libs/color-sensor/docs/reference/sensors/color-sensor/is-color-detected.md

@@ -0,0 +1,30 @@
+# Is Color Detected
+
+Checks the color is detected
+
+```sig
+let b = sensors.color1.isColorDetected(ColorSensorColor.Blue)
+```
+
+The [color](/reference/sensors/color) you choose to look for is one of the colors that the sensor can detect. If you want to use colors for tracking, it's best to use a color that is the same or very close to the ones the sensor detects.
+
+## Parameters
+
+* **color**: the [color](/reference/sensors/color) to watch for.
+
+## Example
+
+Wait for the sensor to see ``blue``. Then, show an expression on the screen.
+
+```blocks
+brick.showString("Waiting for blue", 1)
+while(!sensors.color1.isColorDetected(ColorSensorColor.Blue)) {
+    pause(20)
+}
+brick.clearScreen()
+brick.showImage(images.expressionsSick)
+```
+
+## See also
+
+[on color detected](/reference/sensors/color-sensor/on-color-detected), [color](/reference/sensors/color)

libs/core/input.ts

@@ -1,4 +1,7 @@
 namespace sensors.internal {
+    const UART_PORT_CHANGED = 1
+    const UART_DATA_READY = 8
+
     export class Poller {
         private query: () => number;
         private update: (previous: number, current: number) => void;
@@ -36,6 +39,7 @@ namespace sensors.internal {
 
         private poll() {
             control.runInBackground(() => {
+                pause(this.interval);
                 this.lastQuery = this.lastPause = control.millis();
                 this.previousValue = this.currentValue = this.query();
                 this.update(this.previousValue, this.currentValue);
@@ -60,8 +64,6 @@ namespace sensors.internal {
     let uartMM: MMap
     let IICMM: MMap
     let powerMM: MMap
-    let devcon: Buffer
-    let devPoller: Poller
     let sensorInfos: SensorInfo[];
 
     let batteryInfo: {
@@ -104,11 +106,10 @@ namespace sensors.internal {
         }
     }
 
-    function init() {
+    export function init() {
         if (sensorInfos) return
         sensorInfos = []
         for (let i = 0; i < DAL.NUM_INPUTS; ++i) sensorInfos.push(new SensorInfo(i))
-        devcon = output.createBuffer(DevConOff.Size)
 
         analogMM = control.mmap("/dev/lms_analog", AnalogOff.Size, 0)
         if (!analogMM) control.fail("no analog sensor")
@@ -121,10 +122,10 @@ namespace sensors.internal {
 
         powerMM = control.mmap("/dev/lms_power", 2, 0)
 
-        devPoller = new Poller(250, () => { return hashDevices(); },
-            (prev, curr) => {
-                detectDevices();
-            });
+        forever(function () {
+            pause(500)
+            detectDevices();
+        })
     }
 
     export function getActiveSensors(): Sensor[] {
@@ -132,16 +133,6 @@ namespace sensors.internal {
         return sensorInfos.filter(si => si.sensor && si.sensor.isActive()).map(si => si.sensor);
     }
 
-    function readUartInfo(port: number, mode: number) {
-        let buf = output.createBuffer(UartCtlOff.Size)
-        buf[UartCtlOff.Port] = port
-        buf[UartCtlOff.Mode] = mode
-        uartMM.ioctl(IO.UART_READ_MODE_INFO, buf)
-        return buf
-        //let info = `t:${buf[TypesOff.Type]} c:${buf[TypesOff.Connection]} m:${buf[TypesOff.Mode]} n:${buf.slice(0, 12).toHex()}`
-        //serial.writeLine("UART " + port + " / " + mode + " - " + info)
-    }
-
     export function readIICID(port: number) {
         const buf = output.createBuffer(IICStr.Size)
         buf[IICStr.Port] = port
@@ -273,35 +264,26 @@ void      cUiUpdatePower(void)
         };
     }
 
-    function hashDevices(): number {
-        const conns = analogMM.slice(AnalogOff.InConn, DAL.NUM_INPUTS)
-        let r = 0;
-        for (let i = 0; i < conns.length; ++i) {
-            r = (r << 8 | conns[i]);
-        }
-        return r;
-    }
-
-    let nonActivated = 0;
     function detectDevices() {
-        //control.dmesg(`detect devices (${nonActivated} na)`)
+        control.dmesg(`detect devices`)
         const conns = analogMM.slice(AnalogOff.InConn, DAL.NUM_INPUTS)
-        let numChanged = 0;
-        const uartSensors: SensorInfo[] = [];
-
+        let devcon: Buffer = undefined;
         for (const sensorInfo of sensorInfos) {
             const newConn = conns[sensorInfo.port]
-            if (newConn == sensorInfo.connType) {
-                // control.dmesg(`connection unchanged ${newConn} at ${sensorInfo.port}`)
+            if (newConn == sensorInfo.connType)
                 continue;
-            }
-            numChanged++
+
             sensorInfo.connType = newConn
             sensorInfo.devType = DAL.DEVICE_TYPE_NONE
+            sensorInfo.sensor = undefined;
+
             if (newConn == DAL.CONN_INPUT_UART) {
                 control.dmesg(`new UART connection at ${sensorInfo.port}`)
-                updateUartMode(sensorInfo.port, 0);
-                uartSensors.push(sensorInfo);
+                const status = getUartStatus(sensorInfo.port);
+                if (status & UART_PORT_CHANGED) {
+                    if (!devcon) devcon = output.createBuffer(DevConOff.Size)
+                    updateUartMode(devcon, sensorInfo.port, 0);
+                }
             } else if (newConn == DAL.CONN_NXT_IIC) {
                 control.dmesg(`new IIC connection at ${sensorInfo.port}`)
                 sensorInfo.devType = DAL.DEVICE_TYPE_IIC_UNKNOWN
@@ -312,32 +294,31 @@ void      cUiUpdatePower(void)
                 // TODO? for now assume touch
                 sensorInfo.devType = DAL.DEVICE_TYPE_TOUCH
             } else if (newConn == DAL.CONN_NONE || newConn == 0) {
-                //control.dmesg(`disconnect at port ${sensorInfo.port}`)
+                control.dmesg(`disconnected port ${sensorInfo.port}`)
+                // clear sensor
+                sensorInfo.sensor = undefined;
             } else {
                 control.dmesg(`unknown connection type: ${newConn} at ${sensorInfo.port}`)
+                // clear sensor
+                sensorInfo.sensor = undefined;
             }
         }
 
-        if (uartSensors.length > 0) {
-            setUartModes();
-            for (const sensorInfo of uartSensors) {
-                let uinfo = readUartInfo(sensorInfo.port, 0)
-                sensorInfo.devType = uinfo[TypesOff.Type]
-                control.dmesg(`UART type ${sensorInfo.devType}`)
-            }
+        if (devcon)
+            setUartModes(devcon);
+
+        for (const sensorInfo of sensorInfos.filter(si => si.connType == DAL.CONN_INPUT_UART && si.devType == DAL.CONN_NONE)) {
+            const uinfo = readUartInfo(sensorInfo.port, 0);
+            sensorInfo.devType = uinfo[TypesOff.Type];
+            control.dmesg(`UART type ${sensorInfo.devType}`)
         }
 
-        if (numChanged == 0 && nonActivated == 0)
-            return
-
-        //control.dmesg(`updating sensor status`)
-        nonActivated = 0;
-        for (const sensorInfo of sensorInfos) {
+        // assign sensors
+        for (const sensorInfo of sensorInfos.filter(si => !si.sensor)) {
             if (sensorInfo.devType == DAL.DEVICE_TYPE_IIC_UNKNOWN) {
                 sensorInfo.sensor = sensorInfo.sensors.filter(s => s._IICId() == sensorInfo.iicid)[0]
                 if (!sensorInfo.sensor) {
                     control.dmesg(`sensor not found for iicid=${sensorInfo.iicid} at ${sensorInfo.port}`)
-                    nonActivated++;
                 } else {
                     control.dmesg(`sensor connected iicid=${sensorInfo.iicid} at ${sensorInfo.port}`)
                     sensorInfo.sensor._activated()
@@ -346,14 +327,29 @@ void      cUiUpdatePower(void)
                 sensorInfo.sensor = sensorInfo.sensors.filter(s => s._deviceType() == sensorInfo.devType)[0]
                 if (!sensorInfo.sensor) {
                     control.dmesg(`sensor not found for type=${sensorInfo.devType} at ${sensorInfo.port}`)
-                    nonActivated++;
                 } else {
                     control.dmesg(`sensor connected type=${sensorInfo.devType} at ${sensorInfo.port}`)
                     sensorInfo.sensor._activated()
                 }
             }
         }
-        //control.dmesg(`detect devices done`)
+
+        // check uart sensors
+        for (const sensorInfo of sensorInfos.filter(si => si.connType == DAL.CONN_INPUT_UART && !!si.sensor)) {
+            const status = getUartStatus(sensorInfo.port);
+            control.dmesg(`UART status ${status} at ${sensorInfo.port}`)
+        }
+    }
+
+    // this function will return a meaningful result only when stats & CHANGED
+    // it is cleared afterwards
+    function readUartInfo(port: number, mode: number) {
+        const buf = output.createBuffer(UartCtlOff.Size)
+        buf[UartCtlOff.Port] = port
+        buf[UartCtlOff.Mode] = mode
+        uartMM.ioctl(IO.UART_READ_MODE_INFO, buf)
+        control.dmesg(`UART_READ_MODE t:${buf[TypesOff.Type]} c:${buf[TypesOff.Connection]} m:${buf[TypesOff.Mode]} n:${buf.slice(0, 12).toHex()}`);
+        return buf
     }
 
     export class Sensor extends control.Component {
@@ -458,7 +454,7 @@ void      cUiUpdatePower(void)
 
         reset() {
             if (this.isActive()) uartReset(this._port);
-            this.realmode = 0;
+            this.realmode = -1;
         }
     }
 
@@ -512,8 +508,8 @@ void      cUiUpdatePower(void)
     export const iicsensor = new IICSensor(3)
 
     function uartReset(port: number) {
-        if (port < 0) return
         control.dmesg(`UART reset at ${port}`)
+        const devcon = output.createBuffer(DevConOff.Size)
         devcon.setNumber(NumberFormat.Int8LE, DevConOff.Connection + port, DAL.CONN_NONE)
         devcon.setNumber(NumberFormat.Int8LE, DevConOff.Type + port, 0)
         devcon.setNumber(NumberFormat.Int8LE, DevConOff.Mode + port, 0)
@@ -521,23 +517,22 @@ void      cUiUpdatePower(void)
     }
 
     function getUartStatus(port: number) {
-        if (port < 0) return 0
         return uartMM.getNumber(NumberFormat.Int8LE, UartOff.Status + port)
     }
 
-    function waitNonZeroUartStatus(port: number) {
-        while (true) {
-            if (port < 0) return 0
-            let s = getUartStatus(port)
-            if (s) return s
+    function waitNonZeroUartStatus(port: number): number {
+        let retry = 20;
+        while (retry-- > 0) {
+            const s = getUartStatus(port)
+            if (s) return s;
+            control.dmesg(`UART status 0, waiting...`)
             pause(25)
         }
+        return 0
     }
 
     function uartClearChange(port: number) {
         control.dmesg(`UART clear change`);
-        const UART_DATA_READY = 8
-        const UART_PORT_CHANGED = 1
         while (true) {
             let status = getUartStatus(port)
             if (port < 0) break
@@ -545,10 +540,11 @@ void      cUiUpdatePower(void)
             if ((status & UART_DATA_READY) != 0 && (status & UART_PORT_CHANGED) == 0)
                 break
 
+            const devcon = output.createBuffer(DevConOff.Size)
             devcon.setNumber(NumberFormat.Int8LE, DevConOff.Connection + port, DAL.CONN_INPUT_UART)
             devcon.setNumber(NumberFormat.Int8LE, DevConOff.Type + port, 0)
             devcon.setNumber(NumberFormat.Int8LE, DevConOff.Mode + port, 0)
-
+            control.dmesg(`UART_CLEAR_CHANGED status ${status} ${devcon.toHex()}`)
             uartMM.ioctl(IO.UART_CLEAR_CHANGED, devcon)
 
             uartMM.setNumber(NumberFormat.Int8LE, UartOff.Status + port,
@@ -557,8 +553,8 @@ void      cUiUpdatePower(void)
         }
     }
 
-    function setUartModes() {
-        control.dmesg(`UART set modes`)
+    function setUartModes(devcon: Buffer) {
+        control.dmesg(`UART_SET_CONN ${devcon.toHex()}`)
         uartMM.ioctl(IO.UART_SET_CONN, devcon)
         const ports: number[] = [];
         for (let port = 0; port < DAL.NUM_INPUTS; ++port) {
@@ -570,22 +566,23 @@ void      cUiUpdatePower(void)
         while (ports.length) {
             const port = ports.pop();
             const status = waitNonZeroUartStatus(port)
-            control.dmesg(`UART set mode ${status} at ${port}`);
+            control.dmesg(`UART status ${status} at ${port}`);
         }
     }
 
-    function updateUartMode(port: number, mode: number) {
-        control.dmesg(`UART set mode to ${mode} at ${port}`)
+    function updateUartMode(devcon: Buffer, port: number, mode: number) {
+        control.dmesg(`UART update mode to ${mode} at ${port}`)
         devcon.setNumber(NumberFormat.Int8LE, DevConOff.Connection + port, DAL.CONN_INPUT_UART)
         devcon.setNumber(NumberFormat.Int8LE, DevConOff.Type + port, 33)
         devcon.setNumber(NumberFormat.Int8LE, DevConOff.Mode + port, mode)
     }
 
     function setUartMode(port: number, mode: number) {
-        const UART_PORT_CHANGED = 1
+        control.dmesg(`UART set mode ${mode} at ${port}`);
         while (true) {
-            if (port < 0) return
-            updateUartMode(port, mode);
+            const devcon = output.createBuffer(DevConOff.Size)
+            updateUartMode(devcon, port, mode);
+            control.dmesg(`UART_SET_CONN ${devcon.toHex()}`)
             uartMM.ioctl(IO.UART_SET_CONN, devcon)
             let status = waitNonZeroUartStatus(port)
             if (status & UART_PORT_CHANGED) {
@@ -593,7 +590,8 @@ void      cUiUpdatePower(void)
                 uartClearChange(port)
             } else {
                 control.dmesg(`UART status ${status}`);
-                break;
+                if (status & UART_DATA_READY)
+                    break;
             }
             pause(10)
         }
@@ -616,6 +614,7 @@ void      cUiUpdatePower(void)
 
     export function setIICMode(port: number, type: number, mode: number) {
         if (port < 0) return;
+        const devcon = output.createBuffer(DevConOff.Size)
         devcon.setNumber(NumberFormat.Int8LE, DevConOff.Connection + port, DAL.CONN_NXT_IIC)
         devcon.setNumber(NumberFormat.Int8LE, DevConOff.Type + port, type)
         devcon.setNumber(NumberFormat.Int8LE, DevConOff.Mode + port, mode)
@@ -624,7 +623,7 @@ void      cUiUpdatePower(void)
 
     export function transactionIIC(port: number, deviceAddress: number, writeBuf: number[], readLen: number) {
         if (port < 0) return;
-        let iicdata = output.createBuffer(IICDat.Size)
+        const iicdata = output.createBuffer(IICDat.Size)
         iicdata.setNumber(NumberFormat.Int8LE, IICDat.Port, port)
         iicdata.setNumber(NumberFormat.Int8LE, IICDat.Repeat, 0)
         iicdata.setNumber(NumberFormat.Int16LE, IICDat.Time, 0)

libs/core/output.ts

@@ -55,7 +55,7 @@ namespace motors {
         Size = 12
     }
 
-    function init() {
+    export function init() {
         if (pwmMM) return
         pwmMM = control.mmap("/dev/lms_pwm", 0, 0)
         if (!pwmMM) control.fail("no PWM file")

libs/ev3/startup.ts

@@ -2,5 +2,6 @@
 console.addListener(function(priority: ConsolePriority, msg: string) {
     control.dmesg(msg.substr(0, msg.length - 1))
 })
+
 // boot sequence
 brick.showBoot();

libs/screen/targetoverrides.ts

@@ -141,6 +141,8 @@ namespace brick {
         const col = 44;
         const lineHeight8 = image.font8.charHeight + 2;
         const h = screen.height;
+        const w = screen.width;
+        const blink = (control.millis() >> 5) % (h - 1);
 
         clearScreen();
 
@@ -180,21 +182,23 @@ namespace brick {
             if (inf)
                 screen.print(inf, x, h - 2 * lineHeight8, 1, inf.length > 4 ? image.font5 : image.font8);
         }
+
+        // alive dot
+        screen.setPixel(w - 1, blink, 1);
+        screen.setPixel(w - 1, blink - 1, 1);
+        screen.setPixel(w - 2, blink - 1, 1);
+        screen.setPixel(w - 2, blink, 1);
     }
 
     export function showBoot() {
         // pulse green, play startup sound, turn off light
         brick.setStatusLight(StatusLight.GreenPulse);
         // We pause for 100ms to give time to read sensor values, so they work in on_start block
-        pause(400)
+        sensors.internal.init();
+        motors.init();
+        pause(800)
         // and we're ready
         brick.setStatusLight(StatusLight.Off);
-        // always show port by default if no UI is set
-        control.runInParallel(function () {
-            // show ports if nothing is has been shown
-            if (screenMode != ScreenMode.None) return;
-            showPorts();
-        })
     }
 
     /**

package.json

@@ -1,6 +1,6 @@
 {
   "name": "pxt-ev3",
-  "version": "1.4.7",
+  "version": "1.4.8",
   "description": "LEGO MINDSTORMS EV3 for Microsoft MakeCode",
   "private": false,
   "keywords": [
@@ -45,8 +45,8 @@
     "@types/web-bluetooth": "0.0.4"
   },
   "dependencies": {
-    "pxt-common-packages": "6.16.10",
-    "pxt-core": "5.25.13"
+    "pxt-common-packages": "6.16.18",
+    "pxt-core": "5.28.8"
   },
   "scripts": {
     "test": "node node_modules/pxt-core/built/pxt.js travis"

targetconfig.json

@@ -27,6 +27,6 @@
         "Tutorial Videos": "videos"
     },
     "electronManifest": {
-        "latest": "v1.2.22"
+        "latest": "v1.2.26"
     }
 }