1.4.5

* account for polarity

* more comments

* handle dual motor in runtime

* invert steer

* don't use firmware polarity

docs/reference/brick/exit-program.md

@@ -0,0 +1,18 @@
+# exit Program
+
+Stops the program and returns to the brick menu
+
+```sig
+brick.exitProgram();
+```
+
+## Example
+
+Do a sequence of motor commands and stop the program.
+
+```blocks
+motors.largeA.run(50)
+pause(500)
+motors.stopAll()
+brick.exitProgram();
+```

libs/core/battery.ts

@@ -26,6 +26,7 @@ namespace brick {
      */
     //% blockId=brickBatteryProperty block="battery %property"
     //% group="Battery"
+    //% blockGap=8
     //% help=brick/battery-property
     export function batteryInfo(property: BatteryProperty): number {
         const info = sensors.internal.getBatteryInfo();

libs/core/buttons.ts

@@ -85,7 +85,7 @@ namespace brick {
         //% blockId=buttonIsPressed
         //% parts="brick"
         //% blockNamespace=brick
-        //% weight=81 blockGap=8
+        //% weight=81
         //% group="Buttons"
         //% button.fieldEditor="brickbuttons"
         isPressed() {

libs/core/output.ts

@@ -159,6 +159,7 @@ namespace motors {
         private _accelerationTime: number;
         private _decelerationSteps: number;
         private _decelerationTime: number;
+        private _inverted: boolean;
 
         protected static output_types: number[] = [0x7, 0x7, 0x7, 0x7];
 
@@ -176,6 +177,7 @@ namespace motors {
             this._accelerationTime = 0;
             this._decelerationSteps = 0;
             this._decelerationTime = 0;
+            this._inverted = false;
         }
 
         /**
@@ -225,9 +227,11 @@ namespace motors {
         //% help=motors/motor/set-inverted
         setInverted(inverted: boolean) {
             this.init();
-            const b = mkCmd(this._port, DAL.opOutputPolarity, 1)
-            b.setNumber(NumberFormat.Int8LE, 2, inverted ? 0 : 1);
-            writePWM(b)
+            this._inverted = inverted;
+        }
+
+        protected invertedFactor(): number {
+            return this._inverted ? -1 : 1;
         }
 
         /** 
@@ -294,8 +298,9 @@ namespace motors {
         }
 
         private normalizeSchedule(speed: number, step1: number, step2: number, step3: number, unit: MoveUnit): MoveSchedule {
+            // motor polarity is not supported at the firmware level for sync motor operations
             const r: MoveSchedule = {
-                speed: Math.clamp(-100, 100, speed >> 0),
+                speed: Math.clamp(-100, 100, speed | 0) * this.invertedFactor(),
                 useSteps: true,
                 steps: [step1 || 0, step2 || 0, step3 || 0]
             }
@@ -562,6 +567,7 @@ namespace motors {
 
         private __init() {
             this.setOutputType(this._large);
+            this.setInverted(false);
         }
 
         /**
@@ -741,7 +747,7 @@ namespace motors {
         //% help=motors/synced/steer
         steer(turnRatio: number, speed: number, value: number = 0, unit: MoveUnit = MoveUnit.MilliSeconds) {
             this.init();
-            speed = Math.clamp(-100, 100, speed >> 0);
+            speed = Math.clamp(-100, 100, speed >> 0) * this.invertedFactor();
             if (!speed) {
                 this.stop();
                 return;

libs/core/platform.cpp

@@ -120,7 +120,7 @@ void stopLMS() {
         if (!pid)
             continue;
         char namebuf[100];
-        snprintf(namebuf, 1000, "/proc/%d/cmdline", pid);
+        snprintf(namebuf, 100, "/proc/%d/cmdline", pid);
         FILE *f = fopen(namebuf, "r");
         if (f) {
             fread(namebuf, 1, 99, f);
@@ -195,5 +195,42 @@ void target_startup() {
 
 void initKeys() {}
 
+static const char *progPath = "/mnt/ramdisk/prjs/BrkProg_SAVE";
+
+// These are disabled except when building File_manager.pdf
+// %
+void deletePrjFile(String filename) {
+    const char *d = filename->getUTF8Data();
+    if (strlen(d) > 500 || strchr(d, '/'))
+        return;
+    char buf[1024];
+    snprintf(buf, sizeof(buf), "%s/%s", progPath, d);
+    unlink(buf);
+}
+
+// %
+RefCollection *listPrjFiles() {
+    auto res = Array_::mk();
+    registerGCObj(res);
+
+    auto dp = opendir(progPath);
+
+    for (;;) {
+        dirent *ep = dp ? readdir(dp) : NULL;
+        if (!ep)
+            break;
+        if (ep->d_name[0] == '.')
+            continue;
+        auto str = mkString(ep->d_name, -1);
+        registerGCObj(str);
+        res->head.push((TValue)str);
+        unregisterGCObj(str);
+    }
+    if (dp)
+        closedir(dp);
+    unregisterGCObj(res);
+
+    return res;
+}
 
 }

libs/ev3/brick.ts

@@ -0,0 +1,13 @@
+namespace brick {
+    /**
+     * Exits the program to the main menu. (in the simulator restarts it)
+     */
+    //% blockId=loopstop block="exit program"
+    //% help=reference/brick/exit-program
+    //% weight=10
+    //% blockGap=8
+    //% group="Buttons"
+    export function exitProgram() {
+        control.reset();
+    }
+}

libs/ev3/ns.ts

@@ -1,6 +1,6 @@
 
 //% color="#68C3E2" weight=100 icon="\uf106"
-//% groups='["Buttons", "Screen", "Battery"]'
+//% groups='["Buttons", "Screen", "Power"]'
 //% labelLineWidth=60
 namespace brick {
 }

libs/ev3/pxt.json

@@ -2,8 +2,9 @@
     "name": "ev3",
     "description": "The EV3 library",
     "files": [
-        "README.md",
+        "README.md",        
         "ns.ts",
+        "brick.ts",
         "startup.ts",
         "images.jres",
         "images.ts",

package.json

@@ -1,6 +1,6 @@
 {
   "name": "pxt-ev3",
-  "version": "1.4.2",
+  "version": "1.4.5",
   "description": "LEGO MINDSTORMS EV3 for Microsoft MakeCode",
   "private": false,
   "keywords": [
@@ -45,8 +45,8 @@
     "@types/web-bluetooth": "0.0.4"
   },
   "dependencies": {
-    "pxt-common-packages": "6.16.7",
-    "pxt-core": "5.25.6"
+    "pxt-common-packages": "6.16.10",
+    "pxt-core": "5.25.9"
   },
   "scripts": {
     "test": "node node_modules/pxt-core/built/pxt.js travis"

scripts/file_manager.ts

@@ -0,0 +1,97 @@
+//% shim=pxt::listPrjFiles
+function getPrjs() {
+    let programs = [
+        "pxt",
+        "my amazing robot",
+    ]
+    for (let i = 1; i < 6; ++i)
+        programs.push("Untitled-" + i)
+    return programs
+}
+
+//% shim=pxt::deletePrjFile
+function delPrj(fn: string) {
+    return
+}
+
+const programs = getPrjs()
+    .filter(s => s.substr(s.length - 4, 4) == ".rbf")
+    .map(s => s.substr(0, s.length - 4))
+    .filter(s => s != "File_manager")
+
+programs.push("")
+programs.push("Cancel")
+programs.push("Delete 0 files")
+
+let todel: boolean[] = []
+let scrollTop = 0
+let cursor = 0
+let confirm = false
+function showMenu() {
+    if (cursor < scrollTop + 2)
+        scrollTop = cursor - 2
+    else if (cursor > scrollTop + 11)
+        scrollTop = cursor - 11
+    if (scrollTop < 0)
+        scrollTop = 0
+    let num = 0
+    for (let i = 0; i < todel.length; ++i)
+        if (todel[i]) num++
+    programs[programs.length - 1] =
+        confirm ? "Enter to confirm" : "Delete " + num + " file(s)"
+
+    brick.clearScreen()
+
+    const h = brick.lineHeight()
+    for (let i = 0; i < 13; ++i) {
+        const y = i * h
+        const idx = scrollTop + i
+        const fg = idx == cursor ? 0 : 1
+        const bg = idx == cursor ? 1 : 0
+        // screen.fillRect(0, y, screen.width, h, bg);
+        let text = (idx == cursor ? ">" : " ")
+            + (todel[idx] ? "*" : " ")
+            + " "
+            + (programs[scrollTop + i] || "")
+        screen.print(text, 0, y, fg, brick.font);
+    }
+}
+function move(d: number) {
+    confirm = false
+    const nc = cursor + d
+    if (0 <= nc && nc < programs.length)
+        cursor = nc
+    showMenu()
+}
+brick.buttonDown.onEvent(ButtonEvent.Pressed, () => move(1))
+brick.buttonUp.onEvent(ButtonEvent.Pressed, () => move(-1))
+brick.buttonEnter.onEvent(ButtonEvent.Pressed, function () {
+    if (cursor < programs.length - 3) {
+        todel[cursor] = !todel[cursor]
+        move(1)
+    } else if (cursor == programs.length - 3) {
+        // nothing
+    } else if (cursor == programs.length - 2) {
+        control.reset()
+    } else if (cursor == programs.length - 1) {
+        if (todel.every(x => !x))
+            return
+        if (confirm) {
+            brick.clearScreen()
+            brick.showString("deleting...", 6)
+            for (let i = 0; i < todel.length; ++i) {
+                if (todel[i]) {
+                    delPrj(programs[i] + ".elf")
+                    delPrj(programs[i] + ".rbf")
+                }
+            }
+            pause(1000)
+            control.reset()
+        } else {
+            confirm = true
+            showMenu()
+        }
+    }
+})
+showMenu()
+

sim/state/motornode.ts

@@ -9,7 +9,6 @@ namespace pxsim {
         private angle: number = 0;
         private tacho: number = 0;
         private speed: number = 0;
-        private polarity: number = 1; // -1, 1 or -1
 
         private started: boolean;
         private speedCmd: DAL;
@@ -31,7 +30,7 @@ namespace pxsim {
         }
 
         getSpeed() {
-            return Math.round(this.speed * (!this._synchedMotor && this.polarity == 0 ? -1 : 1));
+            return Math.round(this.speed);
         }
 
         getAngle() {
@@ -82,16 +81,6 @@ namespace pxsim {
             return this.id == NodeType.LargeMotor;
         }
 
-        setPolarity(polarity: number) {
-            // Either 1 or 255 (reverse)
-            /*
-                -1 : Motor will run backward  
-                0 : Motor will run opposite direction  
-                1 : Motor will run forward             
-            */
-            this.polarity = polarity;
-        }
-
         reset() {
             // not sure what reset does...
         }

sim/state/output.ts

@@ -119,11 +119,7 @@ namespace pxsim {
                             return 2;
                         }
                         case DAL.opOutputPolarity: {
-                            // reverse
-                            const port = buf.data[1];
-                            const polarity = pxsim.BufferMethods.getNumber(buf, BufferMethods.NumberFormat.Int8LE, 2);
-                            const motors = ev3board().getMotor(port);
-                            motors.forEach(motor => motor.setPolarity(polarity));
+                            console.error("opOutputPolarity not supported");
                             return 2;
                         }
                         case DAL.opOutputSetType: {